Skip to content

Spanner: Optimize execution speed of test cases #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 4 commits into from
Sep 18, 2019
Merged

Spanner: Optimize execution speed of test cases #6266

olavloite merged 4 commits into from
Sep 18, 2019

Conversation

@olavloite
Copy link

@olavloite olavloite commented Sep 13, 2019 •
edited
Loading

This PR optimizes the execution of different unit tests.
I've gone through all the unit tests to reduce retry delays where possible, including retry info in AbortedExceptions, and reduced waiting times for certain conditions to become true.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #6266 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6266      +/-   ##
============================================
- Coverage     47.11%   46.82%   -0.29%     
  Complexity    27378    27378              
============================================
  Files          2524     2524              
  Lines        277617   277483     -134     
  Branches      31984    31148     -836     
============================================
- Hits         130786   129926     -860     
+ Misses       137056   136978      -78     
- Partials       9775    10579     +804
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.65% <0%> (-6.45%) 147% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.01% <0%> (-5.89%) 39% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812019b...61d4e00. Read the comment docs.

@olavloite olavloite requested a review from skuruppu September 13, 2019 15:47
@olavloite olavloite merged commit 445076a into googleapis:master Sep 18, 2019
@olavloite olavloite deleted the spanner-optimize-test-cases branch September 18, 2019 14:22
@chingor13 chingor13 mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @skuruppu @googlebot