Skip to content

Bigquery: Fix use_avro_logical_types for export jobs. #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 3 commits into from
Sep 13, 2019
Merged

Bigquery: Fix use_avro_logical_types for export jobs. #6260

pmakani merged 3 commits into from
Sep 13, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Sep 12, 2019

Fixes #6199

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #6260 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6260      +/-   ##
============================================
+ Coverage      47.1%    47.1%   +<.01%     
  Complexity    27376    27376              
============================================
  Files          2524     2524              
  Lines        277599   277607       +8     
  Branches      31983    31983              
============================================
+ Hits         130772   130777       +5     
- Misses       137053   137055       +2     
- Partials       9774     9775       +1
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/ExtractJobConfiguration.java 96.47% <100%> (+0.36%) 23 <1> (+1) ⬆️
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86.5% <0%> (-1%) 36% <0%> (-1%)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.11% <0%> (-0.35%) 40% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9946f7...1061b71. Read the comment docs.

@pmakani pmakani requested a review from shollyman September 12, 2019 13:29
shollyman
shollyman approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the comment on the getter, other than that looks good.

...s/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExtractJobConfiguration.java Outdated
return compression;
}

/** Returns True/False. Indicates whether the AVRO logical types is interpreted. */
Copy link
Contributor

@shollyman shollyman Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicates whether exported avro files include logical type annotations.

@pmakani pmakani merged commit c3f1d17 into googleapis:master Sep 13, 2019
@pmakani pmakani deleted the api-bigquery-6199 branch September 13, 2019 07:02
@chingor13 chingor13 mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigquery: implement support use_avro_logical_types for export jobs

3 participants

@pmakani @shollyman @googlebot