storage benchwrapper: update google-cloud-storage version and keep in sync #6251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
1 task
Codecov Report
@@ Coverage Diff @@
## master #6251 +/- ##
=========================================
Coverage ? 47.19%
Complexity ? 27536
=========================================
Files ? 2548
Lines ? 278673
Branches ? 31989
=========================================
Hits ? 131510
Misses ? 137382
Partials ? 9781Continue to review full report at Codecov.
|
jeanbza
approved these changes
Sep 11, 2019
jeanbza
left a comment
jeanbza
left a comment
There was a problem hiding this comment.
Does this actually get used? My understanding was that some maven magic made the locally-installed jars get used.
kolea2
approved these changes
Sep 11, 2019
Contributor
|
@jadekler yep! This version number will now get bumped every time we do a release or snapshot bump with this annotation (part of releasetool) |
|
Sounds good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.