Skip to content

Bigtable: Add an integration test for large rows #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 4 commits into from
Sep 5, 2019
Merged

Bigtable: Add an integration test for large rows #6204

igorbernstein2 merged 4 commits into from
Sep 5, 2019

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Aug 30, 2019

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Aug 30, 2019
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #6204 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6204      +/-   ##
============================================
- Coverage     47.51%   47.23%   -0.29%     
  Complexity    27460    27460              
============================================
  Files          2526     2526              
  Lines        274681   274541     -140     
  Branches      31402    30579     -823     
============================================
- Hits         130521   129674     -847     
+ Misses       134528   134446      -82     
- Partials       9632    10421     +789
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.8% <0%> (-6.45%) 143% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cede9f...9899910. Read the comment docs.

kolea2
kolea2 reviewed Aug 30, 2019
View reviewed changes
...nts/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/LargeRowIT.java Outdated
@ClassRule public static TestEnvRule testEnvRule = new TestEnvRule();

@Test
public void test() throws Exception {
Copy link
Contributor

@kolea2 kolea2 Aug 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - please rename 'test'

@igorbernstein2 igorbernstein2 merged commit e01b39a into googleapis:master Sep 5, 2019
@igorbernstein2 igorbernstein2 deleted the large-rows branch September 5, 2019 15:16
@chingor13 chingor13 mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kolea2 kolea2 kolea2 left review comments

@rahulKQL rahulKQL rahulKQL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@igorbernstein2 @rahulKQL @kolea2 @googlebot @yoshi-kokoro