Spanner: Session pool should return sessions in LIFO order #6178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the session pool return sessions in LIFO order as this decreases the chance that a client is handed a session that has had its server side caches and connections closed. By returning sessions in LIFO order, the P99 latency for queries, especially in typical 1QPS load scenarios, is reduced. Updates googleapis#6169
googlebot
added
the
cla: yes
skuruppu
approved these changes
Aug 28, 2019
| session4.close(); | ||
|
|
||
| Session rw1 = pool.getReadWriteSession(); | ||
| Session rw2 = pool.getReadWriteSession(); |
There was a problem hiding this comment.
[nit] Naming wise, I would call these session5 and session6 to be consistent with the variable naming elsewhere in this test and file, and since the type is not relevant.
Author
There was a problem hiding this comment.
Renamed to session5 and session6.
Codecov Report
@@ Coverage Diff @@
## master #6178 +/- ##
============================================
+ Coverage 47.5% 47.5% +<.01%
- Complexity 27432 27447 +15
============================================
Files 2523 2523
Lines 274592 274592
Branches 31401 31396 -5
============================================
+ Hits 130439 130445 +6
+ Misses 134520 134514 -6
Partials 9633 9633
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the session pool return sessions in LIFO order, as this decreases the chance that a client is handed a session that has had its server side caches and connections closed. By returning sessions in LIFO order, the P99 latency for queries, especially in typical 1QPS load scenarios, is reduced.
Updates #6169