spanner-jdbc: Unflake ITTransactionRetryTest #6159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6159 +/- ##
============================================
+ Coverage 47.38% 47.38% +<.01%
- Complexity 27182 27183 +1
============================================
Files 2524 2524
Lines 274612 274612
Branches 31383 31383
============================================
+ Hits 130125 130126 +1
Misses 134874 134874
+ Partials 9613 9612 -1
Continue to review full report at Codecov.
|
kolea2
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exact number of times a transaction aborted cannot be be predicted, only the minimum number of aborts.
Fixes flake https://source.cloud.google.com/results/invocations/014c5a4b-cc16-4795-a707-f15f2b3a8029/targets/github%2Fgoogle-cloud-java%2Fgoogle-cloud-clients%2Fgoogle-cloud-contrib%2Fgoogle-cloud-spanner-jdbc%2Ftarget%2Ffailsafe-reports/tests;group=com.google.cloud.spanner.jdbc.it.ITTransactionRetryTest%28sponge_log%29;test=testAbortWithUnseenConcurrentInsert;row=1