spanner-jdbc: Add tests for AbstractJdbcResultSet #6156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the hint is currently not used, it is better to keep track of it to keep the get/set methods consistent. According to the JDBC spec, these methods must be implemented, but it is not required that the driver actually uses the hint.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6156 +/- ##
============================================
+ Coverage 47.38% 47.42% +0.04%
- Complexity 27182 27296 +114
============================================
Files 2524 2524
Lines 274612 274613 +1
Branches 31383 31383
============================================
+ Hits 130125 130239 +114
+ Misses 134874 134761 -113
Partials 9613 9613
Continue to review full report at Codecov.
|
kolea2
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for methods in
AbstractJdbcResultSet. Also removes unused code fromJdbcResultSetTestclass.This PR also adds functionality for keeping track of the
fetchSizehint of aResultSet. Although the hint is currently not used, it is better to keep track of it to keep the get/set methods consistent. According to the JDBC spec, these methods must be implemented, but it is not required that thedriver actually uses the hint.