spanner-jdbc: Add additional tests for JdbcDatabaseMetaData #6154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud Spanner treats null values as the lowest possible value, and sorts these accordingly. That means that when sort order is descending, null values will be sorted at the end, while when sort order is ascending null values will be sorted at the start. This method should only return true if nulls are ALWAYS sorted at start.
googlebot
added
the
cla: yes
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional test cases for
JdbcDatabaseMetaDataand fixes one wrong return value:nullsAreSortedAtStartshould return false, as Cloud Spanner does not always sort nulls at the start of a result set. Instead, nulls are treated as the smallest possible value, and hence are sorted at the end of a result when sort order is descending.