Skip to content

Bigtable: minor cleanups #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 1 commit into from
Aug 23, 2019
Merged

Bigtable: minor cleanups #6142

igorbernstein2 merged 1 commit into from
Aug 23, 2019

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Aug 22, 2019

No description provided.

@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Aug 22, 2019
@igorbernstein2 igorbernstein2 requested a review from kolea2 August 22, 2019 21:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019 •
edited
Loading

Codecov Report

Merging #6142 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6142      +/-   ##
============================================
- Coverage     47.38%   47.02%   -0.37%     
+ Complexity    27197    25732    -1465     
============================================
  Files          2523     2523              
  Lines        274600   269325    -5275     
  Branches      31378    31185     -193     
============================================
- Hits         130124   126647    -3477     
+ Misses       134863   134000     -863     
+ Partials       9613     8678     -935
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 91.48% <ø> (+1.9%) 32 <0> (ø) ⬇️
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 98.44% <ø> (-0.03%) 21 <0> (-1)
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 80% <ø> (ø) 23 <0> (-4) ⬇️
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e97c3...f01b44b. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit 7c2f465 into googleapis:master Aug 23, 2019
@igorbernstein2 igorbernstein2 deleted the minor-cleanup branch August 23, 2019 18:53
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @kolea2 @googlebot