Dialogflow: Add ContextManagementSmokeTest #6086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6086 +/- ##
============================================
- Coverage 47.38% 47.38% -0.01%
+ Complexity 27182 27180 -2
============================================
Files 2523 2523
Lines 274581 274581
Branches 31380 31380
============================================
- Hits 130123 130120 -3
- Misses 134850 134851 +1
- Partials 9608 9610 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
The coverage drop probably isn't right as this PR literally only adds tests. |
chingor13
changed the title
|
The change looks sensible. anything pending for merging the PR? |
kolea2
reviewed
Aug 26, 2019
|
|
||
| public class ContextManagementSmokeTest { | ||
| private static final String PROJECT_ENV_NAME = "GOOGLE_CLOUD_PROJECT"; | ||
| private static final String LEGACY_PROJECT_ENV_NAME = "GCLOUD_PROJECT"; |
Contributor
There was a problem hiding this comment.
do we need to support a legacy name?
Contributor
Author
There was a problem hiding this comment.
I think we're still using that env variable :(
kolea2
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5938