Elevate access level of CollectionReference to support mocking #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
BenWhitehead
approved these changes
Aug 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #6054 +/- ##
============================================
- Coverage 47.43% 47.43% -0.01%
- Complexity 27180 27187 +7
============================================
Files 2522 2522
Lines 274264 274299 +35
Branches 31355 31355
============================================
+ Hits 130095 130110 +15
- Misses 134559 134575 +16
- Partials 9610 9614 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3562