Skip to content

Firestore: Add note about potential flakiness in the new Watch test #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 3 commits into from
Jul 31, 2019
Merged

Firestore: Add note about potential flakiness in the new Watch test #5928

BenWhitehead merged 3 commits into from
Jul 31, 2019

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 30, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2019
@codecov
Copy link

codecov bot commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #5928 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5928      +/-   ##
============================================
+ Coverage     46.51%   46.79%   +0.28%     
  Complexity    25648    25648              
============================================
  Files          2456     2456              
  Lines        267490   267613     +123     
  Branches      29752    30563     +811     
============================================
+ Hits         124414   125241     +827     
- Misses       133033   133113      +80     
+ Partials      10043     9259     -784
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...va/com/google/cloud/http/HttpTransportOptions.java 56.33% <0%> (-1.64%) 10% <0%> (ø)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <0%> (-0.08%) 11% <0%> (ø)
...in/java/io/grafeas/v1/UpdateOccurrenceRequest.java 11.71% <0%> (-0.08%) 11% <0%> (ø)
...ava/io/grafeas/v1/ListNoteOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
...in/java/io/grafeas/v1/ListOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23793b...9d544bc. Read the comment docs.

BenWhitehead
BenWhitehead approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo. Otherwise LGTM.

@BenWhitehead BenWhitehead merged commit 9721022 into master Jul 31, 2019
@BenWhitehead BenWhitehead deleted the schmidt-sebastian-patch-1 branch July 31, 2019 15:17
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenWhitehead BenWhitehead

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian @BenWhitehead @googlebot