Skip to content

Add missing BucketField fields #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 1 commit into from
Jul 30, 2019
Merged

Add missing BucketField fields #5926

JesseLovelace merged 1 commit into from
Jul 30, 2019

Conversation

@JesseLovelace
Copy link
Contributor

@JesseLovelace JesseLovelace commented Jul 30, 2019

Labels and locationType were missing from the BucketField enum

@JesseLovelace JesseLovelace requested a review from frankyn July 30, 2019 21:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2019
@JesseLovelace JesseLovelace merged commit ae5d85a into master Jul 30, 2019
@chingor13 chingor13 deleted the missingbucketfields branch July 30, 2019 22:11
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JesseLovelace @frankyn @googlebot