Skip to content

TextToSpeech: Fix #4595 update default inbound msg size to max #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Jul 30, 2019
Merged

TextToSpeech: Fix #4595 update default inbound msg size to max #5883

chingor13 merged 2 commits into from
Jul 30, 2019

Conversation

@ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Jul 25, 2019

Fixes #4595

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #5883 into master will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5883      +/-   ##
============================================
- Coverage     46.79%   46.41%   -0.38%     
+ Complexity    25648    24189    -1459     
============================================
  Files          2456     2456              
  Lines        267593   262358    -5235     
  Branches      30564    30414     -150     
============================================
- Hits         125225   121779    -3446     
+ Misses       133109   132251     -858     
+ Partials       9259     8328     -931
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
... and 673 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123d374...429208a. Read the comment docs.

chingor13
chingor13 requested changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these synth replacements, we want them to be mostly temporary and fix the issue upstream.

For this one, we should file a feature request to https://github.com/googleapis/gapic-generator to add a gapic config for the maxInboundMessageSize default and add a link to that bug in a comment here.

@chingor13 chingor13 self-assigned this Jul 26, 2019
@ajaaym ajaaym mentioned this pull request Jul 30, 2019
Closed
@chingor13 chingor13 merged commit 3626b89 into googleapis:master Jul 30, 2019
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextToSpeech: RESOURCE_EXAUSTED: gRPC message exceeds maximum size

3 participants

@ajaaym @chingor13 @googlebot