Skip to content

Bulk client regen - builder documentation and Generated annotation #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 9 commits into from
Jul 25, 2019
Merged

Bulk client regen - builder documentation and Generated annotation #5880

chingor13 merged 9 commits into from
Jul 25, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jul 25, 2019 •
edited
Loading

Combining multiple, similar PRs into a single PR:

This is similar to #5850 - these were clients that had outstanding synth PRs so they weren't regenerated at the same time.

This was referenced Jul 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
This was referenced Jul 25, 2019
Closed
Closed
Closed
@chingor13 chingor13 changed the title [CHANGE ME] Combining pull requests Bulk client regen - builder documentation and Generated annotation Jul 25, 2019
@chingor13 chingor13 requested a review from kolea2 July 25, 2019 15:49
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #5880 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5880      +/-   ##
============================================
+ Coverage     46.79%    46.8%   +<.01%     
- Complexity    25648    25670      +22     
============================================
  Files          2456     2456              
  Lines        267593   267745     +152     
  Branches      30564    30566       +2     
============================================
+ Hits         125229   125313      +84     
- Misses       133105   133175      +70     
+ Partials       9259     9257       -2
Impacted Files Coverage Δ Complexity Δ
...ml/v1beta1/stub/PredictionServiceStubSettings.java 83.18% <ø> (ø) 12 <0> (ø) ⬇️
.../cloud/dialogflow/v2beta1/EntityTypesSettings.java 12.28% <ø> (ø) 2 <0> (ø) ⬇️
...le/cloud/gaming/v1alpha/RealmsServiceSettings.java 16.27% <ø> (ø) 2 <0> (ø) ⬇️
...sion/v1p4beta1/stub/ProductSearchStubSettings.java 81.87% <ø> (ø) 29 <0> (ø) ⬇️
...gflow/v2beta1/stub/KnowledgeBasesStubSettings.java 80.3% <ø> (ø) 15 <0> (ø) ⬇️
...ce/v1p2beta1/VideoIntelligenceServiceSettings.java 21.87% <ø> (ø) 2 <0> (ø) ⬇️
...ud/dialogflow/v2/stub/EntityTypesStubSettings.java 87.22% <ø> (ø) 25 <0> (ø) ⬇️
.../com/google/cloud/redis/v1/CloudRedisSettings.java 12.72% <ø> (ø) 2 <0> (ø) ⬇️
...loud/vision/v1/stub/ProductSearchStubSettings.java 81.87% <ø> (ø) 29 <0> (ø) ⬇️
...le/cloud/dialogflow/v2beta1/DocumentsSettings.java 15.55% <ø> (ø) 2 <0> (ø) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98c8e6...b5fc31a. Read the comment docs.

@chingor13 chingor13 merged commit 86a5602 into googleapis:master Jul 25, 2019
@chingor13 chingor13 deleted the pr-merge-5865-5866-5867-5868-5869-5870-5872-5873-5874 branch July 25, 2019 19:34
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chingor13 @kolea2 @googlebot @yoshi-kokoro @yoshi-automation