Skip to content

Add bigtable and storage to conformance-tests module #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 1 commit into from
Jul 26, 2019
Merged

Add bigtable and storage to conformance-tests module #5851

BenWhitehead merged 1 commit into from
Jul 26, 2019

Conversation

@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Jul 24, 2019

Add test protos, test definitions and generated protos to conformance
tests module following the pattern set by firestore.

Bump conformance test to googleapis/conformance-tests@613608b

@BenWhitehead BenWhitehead requested review from chingor13 and kolea2 July 24, 2019 19:02
@BenWhitehead BenWhitehead self-assigned this Jul 24, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019
@BenWhitehead
Add bigtable and storage to conformance-tests module
94f26d6 
Add test protos, test definitions and generated protos to conformance
tests module following the pattern set by firestore.

Bump conformance test to googleapis/conformance-tests@613608b
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #5851 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5851      +/-   ##
============================================
+ Coverage     46.79%   46.79%   +<.01%     
  Complexity    25663    25663              
============================================
  Files          2456     2456              
  Lines        267593   267593              
  Branches      30559    30559              
============================================
+ Hits         125228   125229       +1     
+ Misses       133106   133105       -1     
  Partials       9259     9259
Impacted Files Coverage Δ Complexity Δ
...gflow/v2beta1/stub/KnowledgeBasesStubSettings.java 80.3% <0%> (ø) 15% <0%> (ø) ⬇️
...google/cloud/vision/v1/ImageAnnotatorSettings.java 17.07% <0%> (ø) 2% <0%> (ø) ⬇️
.../dialogflow/v2beta1/stub/ContextsStubSettings.java 80.57% <0%> (ø) 16% <0%> (ø) ⬇️
...stub/GameServerDeploymentsServiceStubSettings.java 88.06% <0%> (ø) 27% <0%> (ø) ⬇️
...le/cloud/gaming/v1alpha/RealmsServiceSettings.java 16.27% <0%> (ø) 2% <0%> (ø) ⬇️
...cloud/vision/v1p4beta1/ImageAnnotatorSettings.java 17.07% <0%> (ø) 2% <0%> (ø) ⬇️
...alogflow/v2beta1/stub/EntityTypesStubSettings.java 87.22% <0%> (ø) 25% <0%> (ø) ⬇️
.../v1beta1/stub/DataLabelingServiceStubSettings.java 84.42% <0%> (ø) 50% <0%> (ø) ⬇️
.../cloud/automl/v1beta1/stub/AutoMlStubSettings.java 87.6% <0%> (ø) 43% <0%> (ø) ⬇️
...loud/vision/v1/stub/ProductSearchStubSettings.java 81.87% <0%> (ø) 29% <0%> (ø) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4a579...94f26d6. Read the comment docs.

@BenWhitehead BenWhitehead merged commit b212217 into googleapis:master Jul 26, 2019
@BenWhitehead BenWhitehead deleted the conformance-tests-bump branch July 26, 2019 19:26
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenWhitehead BenWhitehead

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWhitehead @kolea2 @googlebot