Skip to content

Regenerate spanner client #5780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Aug 12, 2019
Merged

Regenerate spanner client #5780

kolea2 merged 1 commit into from
Aug 12, 2019

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jul 19, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:f1a2e851e5e012c59e1da4125480bb19878f86a4e7fac4f375f2e819956b5aa3
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 178 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 76 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 25 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 30 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2019
@chingor13 chingor13 self-assigned this Jul 24, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019
@chingor13 chingor13 assigned kolea2 and unassigned chingor13 Jul 24, 2019
@chingor13 chingor13 requested a review from kolea2 July 24, 2019 18:33
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@kolea2
Copy link
Contributor

kolea2 commented Aug 11, 2019

@olavloite can you take a look at the failing tests here? I think they are asserting on the current retry behavior so will need to be changed.

@olavloite olavloite mentioned this pull request Aug 12, 2019
Merged
@olavloite
Copy link

olavloite commented Aug 12, 2019

@kolea2 #6065 should fix the test failure.

What does surprise me a little bit is that the retry settings for the following methods have been changed from idempotent to non-idempotent:

  • createDatabase
  • createInstance
  • updateInstance

While updateDatabaseDdl is still configured as idempotent.

I understand why the create... methods have been changed, but regarding the update... methods I have a couple of questions:

  • updateDatabaseDdl: Shouldn't this also be non-idempotent? Executing an operation like CREATE TABLE FOO ... is not something that could normally be retried without side effects.
  • updateInstance: As far as I can see, this method can only be used to set the name, node count and labels. Setting the same values multiple times should (as far as I can tell) not have any side effects, which would allow this method to be configured as idempotent.

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2019
@kolea2
Copy link
Contributor

kolea2 commented Aug 12, 2019

Thanks @olavloite! I will bring this up with the Spanner team.

@kolea2 kolea2 merged commit 5dec125 into master Aug 12, 2019
@kolea2 kolea2 mentioned this pull request Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@olavloite olavloite

@kolea2 kolea2

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yoshi-automation @kolea2 @olavloite @chingor13 @googlebot @yoshi-kokoro