Skip to content

BigQuery: Implement missing list options #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 4 commits into from
Jul 12, 2019
Merged

BigQuery: Implement missing list options #5717

chingor13 merged 4 commits into from
Jul 12, 2019

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 10, 2019 •
edited
Loading

Implements missing DatasetListOption and JobListOptions. This enables users of dataset list to do label-based filtration, and job listing now allows users to bound the job list based on a min/max creation time.

Fixes #5713
Fixes #5712

@shollyman shollyman requested a review from a team as a code owner July 10, 2019 18:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #5717 into master will decrease coverage by 0.7%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5717      +/-   ##
============================================
- Coverage     47.08%   46.37%   -0.71%     
+ Complexity    24993    23557    -1436     
============================================
  Files          2382     2382              
  Lines        259279   254103    -5176     
  Branches      29369    29167     -202     
============================================
- Hits         122074   117833    -4241     
+ Misses       128262   127472     -790     
+ Partials       8943     8798     -145
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 6.08% <0%> (-0.03%) 2 <0> (ø)
.../main/java/com/google/cloud/bigquery/BigQuery.java 77.05% <0%> (-1.39%) 0 <0> (ø)
.../com/google/cloud/bigquery/spi/v2/BigQueryRpc.java 80.95% <100%> (+3.17%) 0 <0> (ø) ⬇️
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...n/java/com/google/cloud/firestore/WriteResult.java 46.15% <0%> (-3.85%) 4% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...age/contrib/nio/SeekableByteChannelPrefetcher.java 63.12% <0%> (-3.13%) 21% <0%> (-2%)
... and 649 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da86687...1eb562e. Read the comment docs.

chingor13
chingor13 requested changes Jul 11, 2019
View reviewed changes
@chingor13 chingor13 changed the title bigquery: implement missing list options BigQuery: Implement missing list options Jul 11, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@chingor13 chingor13 merged commit 10fc3d3 into googleapis:master Jul 12, 2019
@shollyman shollyman deleted the listoptions branch July 12, 2019 16:21
This was referenced Jul 16, 2019
Closed
Closed
Closed
@JesseLovelace JesseLovelace mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@steffnay steffnay steffnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigquery: label filtration on datasets bigquery: implement missing JobListOption filters

5 participants

@shollyman @chingor13 @steffnay @googlebot @yoshi-kokoro