Skip to content

Add additional assertions to DatabaseClientImplTest. #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Jul 10, 2019
Merged

Add additional assertions to DatabaseClientImplTest. #5715

chingor13 merged 2 commits into from
Jul 10, 2019

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jul 10, 2019

No description provided.

@kolea2 kolea2 requested a review from a team as a code owner July 10, 2019 14:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #5715 into master will decrease coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5715      +/-   ##
============================================
- Coverage     46.74%   46.07%   -0.67%     
+ Complexity    24664    23245    -1419     
============================================
  Files          2352     2352              
  Lines        256327   251175    -5152     
  Branches      29359    28419     -940     
============================================
- Hits         119812   115725    -4087     
+ Misses       127582   126665     -917     
+ Partials       8933     8785     -148
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 625 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3288c73...2fd2378. Read the comment docs.

@chingor13 chingor13 merged commit da86687 into googleapis:master Jul 10, 2019
@kolea2 kolea2 mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2 @chingor13 @googlebot