Update the storage mock so that copied objects can be read #5707

philipsdoctor · 2019-07-09T01:42:39Z

Fixes #5705 Allows objects copied with the storage mock to then be read.

googlebot · 2019-07-09T01:42:45Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

philipsdoctor · 2019-07-09T01:44:39Z

...d-nio/src/test/java/com/google/cloud/storage/contrib/nio/testing/LocalStorageHelperTest.java

+    }
+
+    @Test
+    public void testCopyCanBeRead() {


This test reproduces the issue and fails without my fix. An object created by copy cannot be read without raising a NPE. This issue is fixed by this PR.

philipsdoctor · 2019-07-09T01:46:38Z

Hi,
When I check the google CLA site, I see that I am properly signed up through my organization, and that the email matches by github email and my git config email. I'm not sure why this check is failing, if you have any ideas, I'm happy to fix them.

raphaelhamonnais · 2019-07-09T12:08:07Z

Thx @philipsdoctor for proposing this change. I definitely support it.

googlebot · 2019-07-09T16:18:20Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-09T16:37:40Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

chingor13 · 2019-07-09T17:21:13Z

I'm not sure what's up with the googlebot as the commit history looks correct.

googlebot · 2019-07-09T17:21:28Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

philipsdoctor · 2019-07-09T17:49:50Z

Looking into these test failures, apologies, I'll get it fixed up.

googlebot · 2019-07-09T22:20:05Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

philipsdoctor · 2019-07-10T16:56:53Z

@chingor13

I removed the test in error, re-adding it, that was my mistake
this speech-it error is a little vague, I'm not clear why this was non-mergeable?

[07:44:22][ERROR] Cannot check out non-mergeable pull request as if merged.
Please attach a kokoro:force-run label to re-run the Kokoro build when this happens on subsequent commits.

codecov · 2019-07-10T17:23:52Z

Codecov Report

Merging #5707 into master will increase coverage by 0.48%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #5707      +/-   ##
============================================
+ Coverage     46.72%    47.2%   +0.48%     
- Complexity    24647    25189     +542     
============================================
  Files          2351     2389      +38     
  Lines        256149   260580    +4431     
  Branches      29327    29527     +200     
============================================
+ Hits         119688   123018    +3330     
- Misses       127539   128587    +1048     
- Partials       8922     8975      +53

Impacted Files	Coverage Δ	Complexity Δ
...ud/storage/contrib/nio/testing/FakeStorageRpc.java	`60.94% <85.71%> (-3.65%)`	`44 <0> (+2)`
.../main/java/com/google/cloud/bigquery/BigQuery.java	`73.3% <0%> (-5.14%)`	`0% <0%> (ø)`
...n/java/com/google/cloud/bigquery/BigQueryImpl.java	`78.36% <0%> (-1.64%)`	`93% <0%> (+36%)`
...d/storage/contrib/nio/CloudStorageReadChannel.java	`79.76% <0%> (-1.2%)`	`18% <0%> (-1%)`
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java	`61.53% <0%> (-0.97%)`	`8% <0%> (+2%)`
.../com/google/cloud/pubsub/v1/MessageDispatcher.java	`85.12% <0%> (-0.74%)`	`23% <0%> (ø)`
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java	`5.84% <0%> (-0.26%)`	`3% <0%> (+1%)`
...bigtable/admin/v2/BigtableInstanceAdminClient.java	`98.9% <0%> (-0.23%)`	`69% <0%> (+25%)`
...gle/cloud/bigtable/data/v2/BigtableDataClient.java	`89.47% <0%> (-0.11%)`	`64% <0%> (+32%)`
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bba989...b0aa248. Read the comment docs.

Update the storage mock so that copied objects can be read

8a89b91

philipsdoctor requested a review from a team as a code owner July 9, 2019 01:42

philipsdoctor commented Jul 9, 2019

View reviewed changes

sduskis added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2019

sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019

Fixed java file formatting

627ef40

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 9, 2019

chingor13 assigned JesseLovelace Jul 9, 2019

chingor13 added the api: storage Issues related to the Cloud Storage API. label Jul 9, 2019

chingor13 added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 9, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019

Start generation counting at 1, which matches the docs and other tests

6bda52b

chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019

Add back in test file that was accidentally removed

89d33fe

chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019

Reformat code per standards

b0aa248

JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019

JesseLovelace approved these changes Jul 15, 2019

View reviewed changes

JesseLovelace merged commit d284774 into googleapis:master Jul 15, 2019

JesseLovelace mentioned this pull request Jul 17, 2019

Release v0.101.0 #5761

Merged

Update the storage mock so that copied objects can be read #5707

Update the storage mock so that copied objects can be read #5707

Uh oh!

Conversation

philipsdoctor commented Jul 9, 2019

Uh oh!

googlebot commented Jul 9, 2019

Uh oh!

philipsdoctor Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

philipsdoctor commented Jul 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raphaelhamonnais commented Jul 9, 2019

Uh oh!

googlebot commented Jul 9, 2019

Uh oh!

googlebot commented Jul 9, 2019

Uh oh!

chingor13 commented Jul 9, 2019

Uh oh!

googlebot commented Jul 9, 2019

Uh oh!

philipsdoctor commented Jul 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jul 9, 2019

Uh oh!

philipsdoctor commented Jul 10, 2019

Uh oh!

codecov bot commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

philipsdoctor commented Jul 9, 2019 •

edited

Loading

philipsdoctor commented Jul 9, 2019 •

edited

Loading

codecov bot commented Jul 10, 2019 •

edited

Loading