Spanner: Min backoff should be 250ms #5647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
Hmm.. I thought the 250 ms was picked up by this PR: #5523. Is this still needed? |
Author
|
The 250ms is picked up for all timeouts for normal gRPC calls. It is not automatically picked up for the custom retry logic in the Spanner library that is still used for:
(I.e. the places referenced in this comment: #5544 (comment)) |
Contributor
|
Apologies, just read through the issue. I think this should be picked up automatically and we shouldn't rely on hardcoded constants - let's go back to the issue and figure out where that should go to work as expected. Separately, can we move the session not found commit to a new PR? |
Author
|
I'll move the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5544