Logging : Cleanup dependency #5645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
elharo
reviewed
Jul 2, 2019
| <artifactId>grpc-google-cloud-logging-v2</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
Contributor
There was a problem hiding this comment.
This one is very surprising. Do we really not have any unit tests for this code? Maybe they're somewhere else?
Contributor
There was a problem hiding this comment.
defintiely something weird: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java is a junit test that seems to be controlled by this pom.xml.
Can someone explain what's going on here? Are the tests not run? Is the dependency pulled in from a parent?
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sduskis
approved these changes
Jul 3, 2019
Contributor
sduskis
left a comment
sduskis
left a comment
There was a problem hiding this comment.
Spanner is failing in Java 11 tests, but that shouldn't be related to this PR
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* cleanup unused dependency of contrib-google-cloud-logging * remove unused dependency of logging * add the newline at the end of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #4383