Skip to content

Language : Cleanup dependency #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 3 commits into from
Jul 3, 2019
Merged

Language : Cleanup dependency #5644

sduskis merged 3 commits into from
Jul 3, 2019

Conversation

@athakor
Copy link
Contributor

@athakor athakor commented Jul 2, 2019

towards #4383

@athakor athakor requested a review from a team as a code owner July 2, 2019 10:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@codecov
Copy link

codecov bot commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #5644 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5644      +/-   ##
============================================
+ Coverage     46.71%   46.71%   +<.01%     
  Complexity    24629    24629              
============================================
  Files          2351     2351              
  Lines        256127   256127              
  Branches      29325    29325              
============================================
+ Hits         119642   119648       +6     
+ Misses       127565   127559       -6     
  Partials       8920     8920
Impacted Files Coverage Δ Complexity Δ
...ogle/cloud/talent/v4beta1/TenantServiceClient.java 59.25% <0%> (ø) 22% <0%> (ø) ⬇️
...oogle/cloud/talent/v4beta1/EventServiceClient.java 42.42% <0%> (ø) 7% <0%> (ø) ⬇️
.../google/cloud/talent/v4beta1/JobServiceClient.java 45.69% <0%> (ø) 34% <0%> (ø) ⬇️
...cloud/talent/v4beta1/ApplicationServiceClient.java 61.17% <0%> (ø) 23% <0%> (ø) ⬇️
...gle/cloud/talent/v4beta1/CompanyServiceClient.java 59.25% <0%> (ø) 22% <0%> (ø) ⬇️
...gle/cloud/talent/v4beta1/ProfileServiceClient.java 47.52% <0%> (ø) 22% <0%> (ø) ⬇️
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️
.../java/com/google/cloud/testing/CommandWrapper.java 96.96% <0%> (+9.09%) 13% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dd67e...9129c2c. Read the comment docs.

@sduskis sduskis merged commit 61a1127 into googleapis:master Jul 3, 2019
@kolea2 kolea2 mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@athakor @sduskis @googlebot @pmakani @yoshi-kokoro