Skip to content

Firestore: Fix float fields to accept in pojos. #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 2 commits into from
Jul 10, 2019
Merged

Firestore: Fix float fields to accept in pojos. #5642

BenWhitehead merged 2 commits into from
Jul 10, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Jul 2, 2019

Fixes #5610

@pmakani pmakani requested a review from a team as a code owner July 2, 2019 10:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@kolea2 kolea2 requested a review from BenWhitehead July 10, 2019 18:35
@BenWhitehead BenWhitehead merged commit ca4336e into googleapis:master Jul 10, 2019
@pmakani pmakani deleted the api-firestore-5610 branch July 16, 2019 04:44
@JesseLovelace JesseLovelace mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firestore: set() does not accept pojos with float fields

5 participants

@pmakani @BenWhitehead @chingor13 @googlebot @yoshi-kokoro