Skip to content

Add VPC-SC positive and negative integration tests in Web Security Scanner #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 7 commits into from
Jul 10, 2019
Merged

Add VPC-SC positive and negative integration tests in Web Security Scanner #5594

chingor13 merged 7 commits into from
Jul 10, 2019

Conversation

@ashishin
Copy link
Contributor

@ashishin ashishin commented Jun 28, 2019

This add VPC-SC positive and negative integration tests in Web Security Scanner.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2019
@ashishin ashishin marked this pull request as ready for review June 28, 2019 23:03
@ashishin ashishin requested a review from a team as a code owner June 28, 2019 23:03
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 1, 2019
chingor13
chingor13 requested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please run mvn com.coveo:fmt-maven-plugin:format to appease the code linter.

@chingor13 chingor13 added the needs work This is a pull request that needs a little love. label Jul 8, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #5594 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5594      +/-   ##
============================================
+ Coverage     46.72%   46.79%   +0.06%     
- Complexity    24647    24993     +346     
============================================
  Files          2351     2382      +31     
  Lines        256149   259161    +3012     
  Branches      29327    28578     -749     
============================================
+ Hits         119688   121270    +1582     
- Misses       127539   128186     +647     
- Partials       8922     9705     +783
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.95% <0%> (-6.46%) 139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 48.92% <0%> (-5.76%) 35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71124ba...597c390. Read the comment docs.

@chingor13 chingor13 self-assigned this Jul 9, 2019
@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed needs work This is a pull request that needs a little love. labels Jul 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
chingor13
chingor13 requested changes Jul 9, 2019
View reviewed changes
ashishin added 2 commits July 10, 2019 11:55
@ashishin
Renamed VpcNegativeTest and VpcPositiveTest to VPCServiceControlNegat…
aa12af5 
…ive and VPCServiceControlPositive respectively. Renamed methods in VPCServiceControlPositiveTest. Changed caught exception in VPCServiceControlNegativeTest.
@ashishin
Renamed exception from nfe to expected.
597c390
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@chingor13 chingor13 merged commit ab6a85b into googleapis:master Jul 10, 2019
@JesseLovelace JesseLovelace mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishin @chingor13 @googlebot @yoshi-kokoro