Skip to content

Logback:Fix null check in LoggingAppender when copies values from MDC to LogEntry labels #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 4 commits into from
Jun 25, 2019
Merged

Logback:Fix null check in LoggingAppender when copies values from MDC to LogEntry labels #5559

sduskis merged 4 commits into from
Jun 25, 2019

Conversation

@abhinav-qlogic
Copy link

@abhinav-qlogic abhinav-qlogic commented Jun 25, 2019

Fixes #5524

@abhinav-qlogic abhinav-qlogic requested a review from a team as a code owner June 25, 2019 14:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #5559 into master will decrease coverage by 0.33%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5559      +/-   ##
============================================
- Coverage     50.86%   50.53%   -0.34%     
- Complexity    24192    24193       +1     
============================================
  Files          2270     2270              
  Lines        230115   230063      -52     
  Branches      25009    24230     -779     
============================================
- Hits         117041   116252     -789     
+ Misses       104436   104421      -15     
- Partials       8638     9390     +752
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/logging/logback/LoggingAppender.java 63.49% <50%> (-0.51%) 28 <0> (+1)
...va/com/google/cloud/compute/v1/InstanceClient.java 48.95% <0%> (-6.46%) 139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 48.92% <0%> (-5.76%) 35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f4bec...82c3614. Read the comment docs.

@sduskis sduskis merged commit 165ac5c into googleapis:master Jun 25, 2019
@JesseLovelace JesseLovelace mentioned this pull request Jun 26, 2019
Merged
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@abhinav-qlogic @sduskis
Logback:Fix null check in LoggingAppender when copies values from MDC…
e35b44d 
… to LogEntry labels (#5559)

* chnages in LoggingAppender for logentry null check

* logging appender null check changes

* test case is added for loggingAppender

* change in test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NPE when LoggingAppender copies values from MDC to LogEntry labels

4 participants

@abhinav-qlogic @sduskis @googlebot @yoshi-kokoro