Skip to content

Split GrafeasClient from ContainerAnalysis #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 9 commits into from
Jun 26, 2019
Merged

Split GrafeasClient from ContainerAnalysis #5556

chingor13 merged 9 commits into from
Jun 26, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 24, 2019 •
edited
Loading

  • Grafeas protos/grpc/client are now split into their own client
    • All the classes are contained in the io.grafeas:grafeas artifact
    • We use synthtool transformations to remove the default endpoint and scopes
  • google-cloud-containeranalysis now takes a dependency on the io.grafeas:grafeas artifact
  • ContainerAnalysisClient can now build you a GrafeasClient using the same settings it was built with
    • The code to provide this is injected via synthtool transformations

@chingor13 chingor13 requested a review from a team as a code owner June 24, 2019 22:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #5556 into master will decrease coverage by 3.85%.
The diff coverage is 6.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5556      +/-   ##
============================================
- Coverage      50.5%   46.65%   -3.86%     
- Complexity    24207    24582     +375     
============================================
  Files          2270     2351      +81     
  Lines        230115   255718   +25603     
  Branches      24979    29320    +4341     
============================================
+ Hits         116218   119296    +3078     
- Misses       104477   127506   +23029     
+ Partials       9420     8916     -504
Impacted Files Coverage Δ Complexity Δ
...ts/grafeas/src/main/java/io/grafeas/v1/Source.java 0% <ø> (ø) 0 <0> (?)
...grafeas/src/main/java/io/grafeas/v1/Discovery.java 84.21% <ø> (ø) 2 <0> (?)
...afeas/src/main/java/io/grafeas/v1/PackageNote.java 0% <ø> (ø) 0 <0> (?)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <ø> (ø) 11 <0> (?)
...grafeas/src/main/java/io/grafeas/v1/ImageNote.java 0% <ø> (ø) 0 <0> (?)
.../grafeas/src/main/java/io/grafeas/v1/NoteKind.java 0% <ø> (ø) 0 <0> (?)
...nts/grafeas/src/main/java/io/grafeas/v1/Image.java 85% <ø> (ø) 2 <0> (?)
...rafeas/src/main/java/io/grafeas/v1/Occurrence.java 4.51% <ø> (ø) 9 <0> (?)
.../grafeas/src/main/java/io/grafeas/v1/Severity.java 0% <ø> (ø) 0 <0> (?)
...rafeas/src/main/java/io/grafeas/v1/Provenance.java 94.23% <ø> (ø) 2 <0> (?)
... and 296 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6197bb5...6725244. Read the comment docs.

@chingor13 chingor13 merged commit 2b3d755 into googleapis:master Jun 26, 2019
@chingor13 chingor13 deleted the grafeas branch June 26, 2019 13:36
@JesseLovelace JesseLovelace mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @sduskis @googlebot