Import firestore conformance tests from googleapis/conformance-tests@32fd66cf7dffe8431643f08b5944108ac10c8bc2 #5541
Conversation
googlebot
added
the
cla: yes
|
@kolea2 Please review |
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Are all the languages using submodules for reading the tests?
They are starting to move in that direction. dotnet is already using sub-module, and ruby is going to move when updating the firestore tests. I will note, the submodule here is purely to track the commit the resources are from, the sub-module does not need to be cloned for the tests to run. The script |
Codecov Report
@@ Coverage Diff @@
## master #5541 +/- ##
============================================
- Coverage 46.71% 46.71% -0.01%
+ Complexity 24630 24624 -6
============================================
Files 2351 2351
Lines 256127 256121 -6
Branches 29325 29323 -2
============================================
- Hits 119650 119645 -5
+ Misses 127558 127557 -1
Partials 8919 8919
Continue to review full report at Codecov.
|
BenWhitehead
changed the title
|
The builds are currently failing because I need to rebase them. Since this PR is dependent on another PR I'll wait to rebase until that PR is merged. The changes in the PR are unrelated to the build failures and can still be reviewed. |
|
Rebased after merge of #5540 and ready for review. |
| @@ -0,0 +1,3 @@ | |||
| [submodule "google-cloud-testing/google-cloud-conformance-tests/conformance-tests"] | |||
| path = google-cloud-testing/google-cloud-conformance-tests/conformance-tests | |||
| url = git@github.com:googleapis/conformance-tests.git | |||
There was a problem hiding this comment.
Just for my understanding, what does this do?
There was a problem hiding this comment.
This file is the definition for the git-submodule which is being used to track which revision the local conformance test resources came from. You can see an example of what it looks like and how it exists in the file tree here.
|
(can't comment on the file as it is too big) Is TestDefinition.java generated or hand written? |
TestDefinition.java is generated from |
|
LGTM, @chingor13 do you have any final comments? |
|
LGTM, but can you add a bit more info on the README for the conformance tests on the relationship between the test protos and the json config files? |
…2fd66c * Add new script generate-conformance-tests.sh that can reliably update the various files that make up the conformance tests. * Currently the script only updates firestore tests. * Updating of the git-submodule linking to conformance-tests is not done by the script, it is expected that the developer will do the bumping. * import proto definition * generate updated TestDefinition from definition * Add individual test files * Add maven profile `gen-conformance-protos` that can be used to generate protos in `com.google.cloud:google-cloud-conformance-tests`
|
@chingor13 Added some details to the README to explain the files and their relationships. I've also rebased the PR on master. |
5 participants
the various files that make up the conformance tests.
* Currently the script only updates firestore tests.
* Updating of the git-submodule linking to conformance-tests is not
done by the script, it is expected that the developer will do the
bumping.
gen-conformance-protosthat can be used to generate protos incom.google.cloud:google-cloud-conformance-testsDepends on #5540