Skip to content

Create new google-cloud-conformance-tests module #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 3 commits into from
Jun 28, 2019
Merged

Create new google-cloud-conformance-tests module #5540

chingor13 merged 3 commits into from
Jun 28, 2019

Conversation

@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Jun 21, 2019

A new module where common code related to conformance tests can be
shared.

  • Includes a rudimentary classpath scanner that can be used to locate
    test definitions. (The firestore test suite currently have 224 test
    definitions.)
    • The classpath scanner includes a suite of tests to ensure it can
      accurately find resources in jar files and directories.
    • Tests have been ran against the following JVMs on Linux x64 and
      verified to pass. 
      openjdk version "1.7.0_75"
OpenJDK Runtime Environment (build 1.7.0_75-b13)
OpenJDK 64-Bit Server VM (build 24.75-b04, mixed mode)

java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

java version "11.0.2" 2019-01-15 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.2+9-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.2+9-LTS, mixed mode)

openjdk version "12" 2019-03-19
OpenJDK Runtime Environment (build 12+33)
OpenJDK 64-Bit Server VM (build 12+33, mixed mode, sharing)

@BenWhitehead BenWhitehead requested a review from a team as a code owner June 21, 2019 22:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2019
@BenWhitehead
Copy link
Contributor Author

BenWhitehead commented Jun 21, 2019

Replacing #5537

@BenWhitehead BenWhitehead mentioned this pull request Jun 21, 2019
Merged
@BenWhitehead
Copy link
Contributor Author

BenWhitehead commented Jun 21, 2019

@kolea2 Please review

@kolea2
Copy link
Contributor

kolea2 commented Jun 24, 2019

Looks ok to me, adding in @chingor13 for a core perspective.

kolea2
kolea2 reviewed Jun 24, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited
Loading

Codecov Report

Merging #5540 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5540      +/-   ##
============================================
+ Coverage     46.39%   46.71%   +0.32%     
  Complexity    24645    24645              
============================================
  Files          2351     2351              
  Lines        256176   256176              
  Branches      29294    29319      +25     
============================================
+ Hits         118853   119683     +830     
+ Misses       127611   127573      -38     
+ Partials       9712     8920     -792
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/storage/testing/RemoteStorageHelper.java 62.6% <0%> (-2.44%) 9% <0%> (ø)
...m/google/cloud/bigquery/QueryJobConfiguration.java 75.15% <0%> (+0.31%) 50% <0%> (ø) ⬇️
...om/google/cloud/bigquery/LoadJobConfiguration.java 88.73% <0%> (+0.45%) 46% <0%> (ø) ⬇️
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.12% <0%> (+0.47%) 44% <0%> (ø) ⬇️
...java/com/google/cloud/firestore/FirestoreImpl.java 83.42% <0%> (+0.57%) 22% <0%> (ø) ⬇️
...main/java/com/google/cloud/storage/BucketInfo.java 84.6% <0%> (+0.58%) 78% <0%> (ø) ⬇️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 80% <0%> (+0.63%) 57% <0%> (ø) ⬇️
.../com/google/cloud/compute/deprecated/DiskInfo.java 96.5% <0%> (+0.69%) 29% <0%> (ø) ⬇️
...om/google/cloud/notification/NotificationInfo.java 90% <0%> (+1%) 26% <0%> (ø) ⬇️
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (+1%) 35% <0%> (ø) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945107b...96bdd66. Read the comment docs.

chingor13
chingor13 requested changes Jun 27, 2019
View reviewed changes
@BenWhitehead
Create new google-cloud-conformance-tests module
385a4d6 
A new module where common code related to conformance tests can be
shared.

* Includes a rudimentary classpath scanner that can be used to locate
  test definitions. (The firestore test suite currently have 224 test
  definitions.)
  * The classpath scanner includes a suite of tests to ensure it can
    accurately find resources in jar files and directories.
  * Tests have been ran against the following JVMs on Linux x64 and
    verified to pass.
    ```
    openjdk version "1.7.0_75"
    OpenJDK Runtime Environment (build 1.7.0_75-b13)
    OpenJDK 64-Bit Server VM (build 24.75-b04, mixed mode)

    java version "1.8.0_201"
    Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
    Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

    java version "11.0.2" 2019-01-15 LTS
    Java(TM) SE Runtime Environment 18.9 (build 11.0.2+9-LTS)
    Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.2+9-LTS, mixed mode)

    openjdk version "12" 2019-03-19
    OpenJDK Runtime Environment (build 12+33)
    OpenJDK 64-Bit Server VM (build 12+33, mixed mode, sharing)
    ```
chingor13
chingor13 requested changes Jun 27, 2019
View reviewed changes
@BenWhitehead
Copy link
Contributor Author

BenWhitehead commented Jun 28, 2019

@chingor13 Requests integrated. Failing windows build appears to be the spanner test that is flaky on windows.

@chingor13 chingor13 merged commit 295eef7 into googleapis:master Jun 28, 2019
@BenWhitehead BenWhitehead deleted the firestore/conformance-tests-migration/step1 branch June 28, 2019 16:45
@BenWhitehead
Copy link
Contributor Author

BenWhitehead commented Jun 28, 2019

Thanks for merging @chingor13!

This was referenced Jul 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@kolea2 kolea2 kolea2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BenWhitehead @kolea2 @chingor13 @googlebot