Storage: add service api to read storage object in to output stream using direct download #5525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ajaaym
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ajaaym
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ajaaym
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
============================================
- Coverage 50.86% 50.85% -0.01%
+ Complexity 24193 24192 -1
============================================
Files 2270 2270
Lines 230115 230151 +36
Branches 25009 25015 +6
============================================
- Hits 117043 117041 -2
- Misses 104435 104472 +37
- Partials 8637 8638 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@frankyn @JesseLovelace can you please review? |
yoshi-automation
added
🚨
JesseLovelace
approved these changes
Jul 8, 2019
|
Is there an estimated time for the next step of adding a public api to download blob using this? @ajaaym |
Contributor
Author
|
@astroyang #5791 is merged yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #3929
Note: This pr just adds the service api. There would be follow up pr to this one which would add public api to download blob as a file or in to output stream using this service api.