Skip to content

Storage: remove reflection to get raw input stream #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajaaym merged 3 commits into from
Jun 19, 2019
Merged

Storage: remove reflection to get raw input stream #5515

ajaaym merged 3 commits into from
Jun 19, 2019

Conversation

@ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Jun 19, 2019

remove reflection to get raw input stream, work towards #3929

@ajaaym ajaaym requested a review from a team as a code owner June 19, 2019 07:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2019
@codecov
Copy link

codecov bot commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #5515 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5515      +/-   ##
============================================
- Coverage     50.85%   50.54%   -0.32%     
+ Complexity    24192    22790    -1402     
============================================
  Files          2270     2270              
  Lines        230125   225272    -4853     
  Branches      25010    24896     -114     
============================================
- Hits         117041   113858    -3183     
+ Misses       104446   103670     -776     
+ Partials       8638     7744     -894
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.84% <0%> (+0.02%) 1 <0> (ø) ⬇️
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 535 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef771bc...a84ace0. Read the comment docs.

@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@ajaaym
Copy link
Contributor Author

ajaaym commented Jun 19, 2019

merging this as codecov failure are unrelated to this change.

@ajaaym ajaaym merged commit c3a7a3d into googleapis:master Jun 19, 2019
@kolea2 kolea2 mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajaaym @chingor13 @googlebot @yoshi-kokoro