Skip to content

Disable doclint on when attaching javadocs at release time #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Jun 14, 2019
Merged

Disable doclint on when attaching javadocs at release time #5479

chingor13 merged 1 commit into from
Jun 14, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 13, 2019

No description provided.

@chingor13 chingor13 requested a review from a team as a code owner June 13, 2019 21:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@chingor13 chingor13 added the release blocking Required feature/issue must be fixed prior to next release. label Jun 13, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2019
@codecov
Copy link

codecov bot commented Jun 13, 2019 •
edited
Loading

Codecov Report

Merging #5479 into master will decrease coverage by 6.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5479      +/-   ##
============================================
- Coverage     50.81%   43.91%    -6.9%     
+ Complexity    24173    22773    -1400     
============================================
  Files          2271     2271              
  Lines        229906   181918   -47988     
  Branches      25005    18278    -6727     
============================================
- Hits         116835    79896   -36939     
+ Misses       104440    94513    -9927     
+ Partials       8631     7509    -1122
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/http/BaseHttpServiceException.java 44.23% <0%> (-17.31%) 8% <0%> (ø)
...le/cloud/compute/v1/stub/HttpJsonNodeTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...cloud/compute/v1/stub/HttpJsonMachineTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...le/cloud/compute/v1/stub/HttpJsonDiskTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...google/cloud/compute/v1/stub/HttpJsonZoneStub.java 71.42% <0%> (-16.08%) 8% <0%> (-1%)
...ogle/cloud/compute/v1/stub/HttpJsonRegionStub.java 71.42% <0%> (-16.08%) 8% <0%> (-1%)
...d/compute/v1/stub/HttpJsonAcceleratorTypeStub.java 73.52% <0%> (-15.9%) 9% <0%> (-1%)
...cloud/compute/v1/stub/HttpJsonLicenseCodeStub.java 73.07% <0%> (-15.33%) 8% <0%> (-1%)
...pute/v1/stub/HttpJsonInterconnectLocationStub.java 71.42% <0%> (-15.24%) 8% <0%> (-1%)
...mpute/v1/stub/HttpJsonRegionInstanceGroupStub.java 76.31% <0%> (-15.23%) 10% <0%> (-1%)
... and 1701 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f482707...b9c644f. Read the comment docs.

@chingor13 chingor13 merged commit 5fb10db into googleapis:master Jun 14, 2019
@chingor13 chingor13 deleted the doclint-none-on-release branch June 14, 2019 18:06
@kolea2 kolea2 mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13 @sduskis @googlebot @yoshi-kokoro