Updated UnsafeByteOperations.unsafeWrap to ByteString.copyFrom
#5473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes googleapis#5030 Updated `UnsafeByteOperations.unsafeWrap` as this is still a `@ExperimentalApi`.
googlebot
added
the
cla: yes
sduskis
approved these changes
Jun 13, 2019
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
I think the performance hit is acceptable here |
igorbernstein2
approved these changes
Jun 13, 2019
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5030
Updated
UnsafeByteOperations.unsafeWrapas this is still a@ExperimentalApi.To confirm the impact I ran
Range.ByteRangeString#prefix1 million times with a bounded random string, I observed that withUnsafeByteOperations.unsafeWraptheir avg is around ~200ms and after update withByteString.copyFromthe new avg is ~220ms.(10% decrement in performance).