Skip to content

Pub/Sub: Shutting down Subscriber executor #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Jun 14, 2019
Merged

Pub/Sub: Shutting down Subscriber executor #5468

sduskis merged 1 commit into from
Jun 14, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Jun 13, 2019 •
edited
Loading

MessageDispatcher has a scheduled future which needed to be shut down so that the Subscriber can shutdown properly. Added a test to make sure that this doesn't happen again.

Works towards #5227

@sduskis
Pub/Sub: Shutting down Subscriber executor
a8e0b7a 
`MessageDispatcher` has a scheduled future which needed to be shut down so that the `Subscriber` can shutdown properly.  Added a test to make sure that this doesn't happen again.
@sduskis sduskis requested a review from a team as a code owner June 13, 2019 00:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@sduskis sduskis merged commit a560bb5 into googleapis:master Jun 14, 2019
@kolea2 kolea2 mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajaaym ajaaym ajaaym approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @ajaaym @googlebot