Skip to content

Conversation

@omrihq
Copy link

@omrihq omrihq commented Jun 8, 2019

Addresses issue: #5451

@omrihq omrihq requested a review from a team as a code owner June 8, 2019 01:31
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 8, 2019
@omrihq
Copy link
Author

omrihq commented Jun 8, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 8, 2019
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@omrihq
Copy link
Author

omrihq commented Jun 11, 2019

@igorbernstein2 Hi, I'm struggling to see the build failure here for formatting, mind pointing me in the right direction?

@igorbernstein2
Copy link

Please run
mvn com.coveo:fmt-maven-plugin:format

@omrihq
Copy link
Author

omrihq commented Jun 11, 2019

Thanks @igorbernstein2, formatted and updated

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@omrihq
Copy link
Author

omrihq commented Jun 11, 2019

Hi @sduskis, seems like all checks have passed, is there someone in specific I should request a review from?


ImmutableSortedMap<String, Value<?>> getProperties() {
/** Returns the properties. */
public ImmutableSortedMap<String, Value<?>> getProperties() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to expose Guava types as part of the public surface area. We may be able to investigate exposing this as a simple Map type.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #5452 into master will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5452      +/-   ##
============================================
+ Coverage     50.13%   50.82%   +0.68%     
- Complexity    22774    24173    +1399     
============================================
  Files          2271     2271              
  Lines        225018   229906    +4888     
  Branches      24839    25005     +166     
============================================
+ Hits         112824   116841    +4017     
- Misses       103704   104434     +730     
- Partials       8490     8631     +141
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/datastore/BaseEntity.java 91.51% <ø> (ø) 28 <0> (ø) ⬇️
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java 57.14% <0%> (-2.39%) 79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 59.84% <0%> (-2.23%) 38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...oogle/cloud/scheduler/v1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (-1.91%) 32% <0%> (ø)
...ontaineranalysis/v1beta1/GrafeasV1Beta1Client.java 60.97% <0%> (-1.41%) 63% <0%> (+15%)
... and 567 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c4d26...b88dc05. Read the comment docs.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@sduskis sduskis merged commit 344fa97 into googleapis:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants