Skip to content

Conversation

@liubonan
Copy link

@liubonan liubonan commented Jun 3, 2019

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@liubonan liubonan requested a review from a team as a code owner June 3, 2019 22:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2019
@liubonan liubonan requested a review from igorbernstein2 June 3, 2019 22:14
@sduskis
Copy link
Contributor

sduskis commented Jun 4, 2019

@liubonan, can you please run mvn com.coveo:fmt-maven-plugin:format to fix the code format?

Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please run the formatter

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 10, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #5286 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5286      +/-   ##
============================================
+ Coverage     50.47%   50.48%   +<.01%     
  Complexity    23875    23875              
============================================
  Files          2258     2258              
  Lines        227482   227482              
  Branches      24978    24978              
============================================
+ Hits         114828   114834       +6     
+ Misses       104035   104029       -6     
  Partials       8619     8619
Impacted Files Coverage Δ Complexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️
.../java/com/google/cloud/testing/CommandWrapper.java 96.96% <0%> (+9.09%) 13% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04900a...296e428. Read the comment docs.

@chingor13 chingor13 changed the title Redundant Code Clean Up. Bigtable: clean up redundant code Jul 30, 2019
@chingor13 chingor13 merged commit 9cfe553 into googleapis:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants