BigQuery: Augment BQ Model metadata. #5214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces extended ML model metadata into the existing CRUD implementation for BigQuery ML models. This implementation exposes the underlying discovery types directly without an abstraction for the ML metadata. Methods that provide this metadata are all marked @BetaApi to indicate the getters may change.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5214 +/- ##
============================================
+ Coverage 50.41% 50.42% +<.01%
- Complexity 23796 23799 +3
============================================
Files 2251 2251
Lines 226836 226874 +38
Branches 24966 24969 +3
============================================
+ Hits 114370 114392 +22
- Misses 103858 103871 +13
- Partials 8608 8611 +3
Continue to review full report at Codecov.
|
sduskis
approved these changes
May 23, 2019
tswast
approved these changes
May 23, 2019
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
LGTM. This is so much nicer than if we had to duplicate all those properties manually.
Contributor
Author
The combination of the annotation, that the representations are effectively read only, and the fact that we pin the discovery artifacts in the maven dependencies makes me much more comfortable here. Assuming no other comments come up, I'll merge it when I'm back in the office tomorrow my time. |
shollyman
added a commit
to shollyman/google-cloud-java
that referenced
this pull request
Jul 12, 2019
This is a breaking change to a @BetaApi within BigQuery. It swaps in a new veneer StandardSQLField type in place of the underlying discovery type for getting information about the feature and label columns from ML models, which was functionality introduced in: googleapis#5214
stephaniewang526
pushed a commit
to googleapis/java-bigquery
that referenced
this pull request
Dec 6, 2019
…ns. (#5732) This is a breaking change to a @BetaApi within BigQuery. It swaps in a new veneer StandardSQLField type in place of the underlying discovery type for getting information about the feature and label columns from ML models, which was functionality introduced in: googleapis/google-cloud-java#5214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces extended ML model metadata into the existing CRUD
implementation for BigQuery ML models. This implementation exposes the
underlying discovery types directly without an abstraction for the ML metadata.
Methods that provide this metadata are all marked @BetaApi to indicate the getters may change.