Spanner use custom thread factory #5167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a custom thread factory for the different underlying gRPC clients makes it easier to debug potential thread problems, as the name of the thread indicates to which client it belongs.
googlebot
added
the
cla: yes
Contributor
|
This looks good, do you think we can add an IT test as well for this? Separately, anything we can test on the transport channel and its threads? |
Setting an executor provider on the stub settings would cause the executors to be shared between the underlying gRPC channels. Instead, each channel should have its own executor. The executor provider is now set on the channel provider again, but the executor provider keeps track of the executors that have been handed out and closes these when the Spanner instance is closed. This approach is equal to the approach that was already used for the spannerWatchdog executor.
Codecov Report
@@ Coverage Diff @@
## master #5167 +/- ##
============================================
+ Coverage 50.38% 50.4% +0.02%
- Complexity 23736 23785 +49
============================================
Files 2248 2251 +3
Lines 226471 226792 +321
Branches 24954 24966 +12
============================================
+ Hits 114109 114320 +211
- Misses 103770 103865 +95
- Partials 8592 8607 +15
Continue to review full report at Codecov.
|
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The actual number of threads is too dependent on random factors to be used for testing. Manual testing by calling ThreadPoolExecutor#prestartAllCoreThreads() shows the desired behavior.
kolea2
reviewed
May 15, 2019
...ents/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
Show resolved
Hide resolved
kolea2
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a custom ThreadFactory for the underlying gRPC clients to make it easier to determine and debug which service has created the threads.