Skip to content

Conversation

@rahulKQL
Copy link

@rahulKQL rahulKQL commented May 8, 2019

Fixes #4229

This change contains a simple example of how to cancel a stream received from BigtableDataClient#readRowsAsync.

@rahulKQL rahulKQL requested a review from a team as a code owner May 8, 2019 18:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@rahulKQL
Copy link
Author

rahulKQL commented May 8, 2019

@igorbernstein2 PTAL, Also please let me know if this sample code needs to be more concrete/realistic.

@rahulKQL rahulKQL changed the title [WIP] [Bigtable] Added StreamController cancel in readRowsAsync docs [Bigtable] Added StreamController cancel in readRowsAsync docs May 8, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@rahulKQL
Copy link
Author

@igorbernstein2
I have addressed both feedback comments. PTAL and merge if it looks good to you.

@igorbernstein2 igorbernstein2 merged commit 2313bb5 into googleapis:master May 10, 2019
@rahulKQL rahulKQL deleted the streamcancel branch May 21, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigtable: add docs demonstrating stream cancellation

5 participants