Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented May 8, 2019

fixes #5123

@elharo elharo requested a review from a team as a code owner May 8, 2019 17:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #5124 into master will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5124      +/-   ##
============================================
+ Coverage     49.73%   50.38%   +0.64%     
- Complexity    22364    23735    +1371     
============================================
  Files          2248     2248              
  Lines        221740   226471    +4731     
  Branches      24073    24954     +881     
============================================
+ Hits         110292   114107    +3815     
- Misses       102998   103771     +773     
- Partials       8450     8593     +143
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java 57.14% <0%> (-2.39%) 79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 59.84% <0%> (-2.23%) 38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...oogle/cloud/scheduler/v1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (-1.91%) 32% <0%> (ø)
... and 545 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19e5d0...58b8a43. Read the comment docs.

@elharo elharo merged commit 229ee93 into master May 8, 2019
@elharo elharo deleted the elharo-patch-3 branch May 8, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud Tasks client library documentation points to beta docs

3 participants