Skip to content

[Bigtable] CreateTableRequest equals and hashCode with unit test #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 3 commits into from
May 10, 2019
Merged

[Bigtable] CreateTableRequest equals and hashCode with unit test #5079

sduskis merged 3 commits into from
May 10, 2019

Conversation

@rahulKQL
Copy link

@rahulKQL rahulKQL commented May 7, 2019

More information: #5066 (comment)

  • Fixed CreateTableRequest#equals & hashCode
  • Added unit test for equals, hashCode & toProto.

rahulKQL added 2 commits May 7, 2019 16:48
@rahulKQL
CreateTableRequest update with unit test
42c691b 
Fix `CreateTableRequest#equals` & `hashCode`
Added unit test for equals, hashCode & toProto.
@rahulKQL
Fix test cases and applied formatting
0c498b3
@rahulKQL rahulKQL requested a review from a team as a code owner May 7, 2019 12:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2019
@rahulKQL
Copy link
Author

rahulKQL commented May 7, 2019

@igorbernstein2 Please have a look

@rahulKQL rahulKQL mentioned this pull request May 7, 2019
Merged
@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label May 7, 2019
@rahulKQL
Copy link
Author

rahulKQL commented May 8, 2019

@igorbernstein2 This PR is ready for another round of review, PTAL.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@codecov
Copy link

codecov bot commented May 10, 2019 •
edited
Loading

Codecov Report

Merging #5079 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5079      +/-   ##
============================================
+ Coverage     50.38%    50.4%   +0.02%     
- Complexity    23735    23785      +50     
============================================
  Files          2248     2251       +3     
  Lines        226478   226785     +307     
  Branches      24954    24966      +12     
============================================
+ Hits         114113   114314     +201     
- Misses       103772   103864      +92     
- Partials       8593     8607      +14
Impacted Files Coverage Δ Complexity Δ
...d/bigtable/admin/v2/models/CreateTableRequest.java 85.18% <100%> (+10.99%) 8 <2> (+2) ⬆️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 80.21% <0%> (-3.89%) 58% <0%> (+5%)
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java 62.5% <0%> (-1.14%) 6% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 6.1% <0%> (-0.83%) 2% <0%> (ø)
.../talent/v4beta1/stub/EventServiceStubSettings.java 78.48% <0%> (-0.27%) 10% <0%> (ø)
...alent/v4beta1/stub/ProfileServiceStubSettings.java 75.32% <0%> (-0.16%) 16% <0%> (ø)
...talent/v4beta1/stub/TenantServiceStubSettings.java 80% <0%> (-0.16%) 15% <0%> (ø)
...alent/v4beta1/stub/CompanyServiceStubSettings.java 80% <0%> (-0.16%) 15% <0%> (ø)
...t/v4beta1/stub/ApplicationServiceStubSettings.java 80.15% <0%> (-0.16%) 15% <0%> (ø)
...ud/talent/v4beta1/stub/JobServiceStubSettings.java 72.48% <0%> (-0.15%) 18% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae4a9d...97406fd. Read the comment docs.

@sduskis sduskis merged commit cc54764 into googleapis:master May 10, 2019
@chingor13 chingor13 mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahulKQL @igorbernstein2 @sduskis @googlebot @yoshi-kokoro