Skip to content

[Bigtable] GCRules.GCRule Javadoc fix for createTable #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 4 commits into from
May 13, 2019
Merged

[Bigtable] GCRules.GCRule Javadoc fix for createTable #5066

chingor13 merged 4 commits into from
May 13, 2019

Conversation

@rahulKQL
Copy link

@rahulKQL rahulKQL commented May 6, 2019

Fixes #4056 and FIxes #4090 (Both of these issues are related to GCRule).

  • Have added a sample code for GCRule in BigtableTableAdminClient's createTable() & createTableAsync().
  • Have added one line note about GCRule execution.

@rahulKQL rahulKQL requested a review from a team as a code owner May 6, 2019 16:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@rahulKQL
Copy link
Author

rahulKQL commented May 6, 2019

@igorbernstein2 Please have a look.

Q: Should we consider to adding this note in client Javadoc as well?

igorbernstein2
igorbernstein2 reviewed May 6, 2019
View reviewed changes
@rahulKQL
Copy link
Author

rahulKQL commented May 6, 2019

@igorbernstein2
I have addressed feedback comments, Please have a fresh look.

igorbernstein2
igorbernstein2 approved these changes May 6, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please follow up with another PR for equality

@rahulKQL rahulKQL mentioned this pull request May 7, 2019
Merged
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2019
@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label May 7, 2019
rahulKQL added 2 commits May 10, 2019 23:30
@rahulKQL
GCRules.GCRule sample code on createTable
12250a6 
Added sample code on createTable, createTableAsync for `GCRules.GCRule` usage.

Added note for GCRules regarding database compaction
@rahulKQL
Addressing review comments
07ac62a 
Updated GCRules note, removed empty params, and updated BigtableTableAdminClient with better example
@codecov
Copy link

codecov bot commented May 10, 2019 •
edited
Loading

Codecov Report

Merging #5066 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5066      +/-   ##
============================================
+ Coverage      50.4%    50.4%   +<.01%     
  Complexity    23785    23785              
============================================
  Files          2251     2251              
  Lines        226785   226791       +6     
  Branches      24966    24966              
============================================
+ Hits         114314   114320       +6     
  Misses       103864   103864              
  Partials       8607     8607
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigtable/admin/v2/models/GCRules.java 68.86% <ø> (ø) 16 <0> (ø) ⬇️
...d/bigtable/admin/v2/models/CreateTableRequest.java 85.18% <ø> (ø) 8 <0> (ø) ⬇️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 78.63% <ø> (ø) 27 <0> (ø) ⬇️
...ud/talent/v4beta1/stub/CompletionStubSettings.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...acatalog/v1beta1/stub/DataCatalogStubSettings.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (ø) 32% <0%> (ø) ⬇️
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java 84.06% <0%> (ø) 20% <0%> (ø) ⬇️
...e/src/main/java/com/google/cloud/storage/Blob.java 82.09% <0%> (ø) 30% <0%> (ø) ⬇️
...ud/talent/v4beta1/stub/JobServiceStubSettings.java 72.63% <0%> (+0.14%) 18% <0%> (ø) ⬇️
...t/v4beta1/stub/ApplicationServiceStubSettings.java 80.3% <0%> (+0.15%) 15% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d6685...fa2afe8. Read the comment docs.

@rahulKQL
Copy link
Author

rahulKQL commented May 10, 2019

@sduskis @igorbernstein2
I have rebased this PR with the latest master. Please have a look.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 13, 2019
igorbernstein2
igorbernstein2 reviewed May 13, 2019
View reviewed changes
igorbernstein2
igorbernstein2 approved these changes May 13, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about the noise, I misread the code

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@chingor13 chingor13 merged commit 00c8bb1 into googleapis:master May 13, 2019
@chingor13 chingor13 mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigtable: update create table docs to demonstrate GCRules usage Bigtable: document that GCRules are only applied during compaction

7 participants

@rahulKQL @igorbernstein2 @chingor13 @googlebot @pmakani @yoshi-automation @yoshi-kokoro