Skip to content

Pub/Sub: Streamining publisher proto creation. #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 30, 2019
Merged

Pub/Sub: Streamining publisher proto creation. #5040

sduskis merged 1 commit into from
Apr 30, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 30, 2019

Using a prebuit List is faster than adding elements one at a time to a proto list.

@sduskis
Pub/Sub: Streamining publisher proto creation.
223856e 
Using a prebuit List is faster than adding elements one at a time to a proto list.
@sduskis sduskis requested a review from a team as a code owner April 30, 2019 16:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2019
@sduskis sduskis merged commit d2f0bc6 into googleapis:master Apr 30, 2019
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @kolea2 @googlebot