Skip to content

Pubsub: Fix Publisher.shutdown should return promptly. #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 30, 2019
Merged

Pubsub: Fix Publisher.shutdown should return promptly. #5039

sduskis merged 1 commit into from
Apr 30, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Apr 30, 2019

Fixes #3687

@pmakani pmakani requested a review from a team as a code owner April 30, 2019 13:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2019
@sduskis sduskis requested review from sduskis and removed request for a team April 30, 2019 13:51
@sduskis sduskis added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 30, 2019
@sduskis sduskis merged commit 59c609f into googleapis:master Apr 30, 2019
@pmakani pmakani deleted the api-pubsub-3687 branch May 1, 2019 05:04
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publisher.shutdown should return promptly

3 participants

@pmakani @sduskis @googlebot