Bigtable: filter out all @InternalApi classed from the javadocs
#5035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally this should be done via a custom doclet that would filter out any classes annotated with `@InternalOnly`, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (googleapis#5019)
igorbernstein2
added
type: cleanup
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5035 +/- ##
=========================================
Coverage 50.34% 50.34%
Complexity 23712 23712
=========================================
Files 2244 2244
Lines 226295 226295
Branches 24964 24964
=========================================
Hits 113929 113929
Misses 103759 103759
Partials 8607 8607Continue to review full report at Codecov.
|
chingor13
approved these changes
Apr 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this should be done via a custom doclet that would filter out any classes annotated with
@InternalOnly, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (#5019)