Pub/Sub: add MessagesBatch.add method #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new `MessagesBatch` method: `private List<OutstandingBatch> add(OutstandingPublish outstandingPublish)`. This method is responsible for adding a new user request in the form of a `OutstandingPublish`, and returning 0-2 `OutstandingBatch`, depending on the state of the current messages in flight, and the size of the new `OutstandingPublish`.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5032 +/- ##
============================================
- Coverage 50.33% 49.99% -0.34%
+ Complexity 23676 23672 -4
============================================
Files 2238 2238
Lines 226057 226006 -51
Branches 24961 24194 -767
============================================
- Hits 113775 112998 -777
+ Misses 103678 103665 -13
- Partials 8604 9343 +739
Continue to review full report at Codecov.
|
kolea2
approved these changes
Apr 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
MessagesBatchmethod:private List<OutstandingBatch> add(OutstandingPublish outstandingPublish).This method is responsible for adding a new user request in the form of a
OutstandingPublish, and returning 0-2OutstandingBatch, depending on the state of the current messages in flight, and the size of the newOutstandingPublish.