Skip to content

Update new client script #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 4 commits into from
Apr 29, 2019
Merged

Update new client script #5028

chingor13 merged 4 commits into from
Apr 29, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 26, 2019 •
edited
Loading

  • -c option for the path to the artman config is now optional
  • add -n option for the pretty name used in the README and pom.xml
  • add -d option for the description used in the README and pom.xml
  • add --docs-url and --overview-url used in the README
  • fix detecting the parent artifact version when generating the pom.xml files
  • removes legacy scripts which are no longer used for generation/release
  • new client versions are no longer versioned with "alpha"

Fixes #4958

@chingor13 chingor13 requested a review from a team as a code owner April 26, 2019 20:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@chingor13 chingor13 added type: process A process-related concern. May include testing, release, or the like. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 26, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@kolea2
Copy link
Contributor

kolea2 commented Apr 29, 2019

This will close #4958 as well yes?

@chingor13
Copy link
Contributor Author

chingor13 commented Apr 29, 2019

Yes this will fix #4958

@chingor13 chingor13 merged commit 029bfe8 into googleapis:master Apr 29, 2019
@chingor13 chingor13 deleted the update-new-client-script branch April 29, 2019 15:45
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update new_client.py to add new clients to the list of modules in google-cloud-clients

4 participants

@chingor13 @kolea2 @sduskis @googlebot