Skip to content

Add Phishing Protection API Client #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 10 commits into from
May 1, 2019
Merged

Add Phishing Protection API Client #5026

chingor13 merged 10 commits into from
May 1, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 26, 2019

No description provided.

@chingor13 chingor13 requested a review from a team as a code owner April 26, 2019 17:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #5026 into master will increase coverage by 0.63%.
The diff coverage is 61.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5026      +/-   ##
============================================
+ Coverage      49.7%   50.33%   +0.63%     
- Complexity    22341    23705    +1364     
============================================
  Files          2244     2244              
  Lines        221570   226250    +4680     
  Branches      24081    24963     +882     
============================================
+ Hits         110122   113893    +3771     
- Misses       102984   103751     +767     
- Partials       8464     8606     +142
Impacted Files Coverage Δ Complexity Δ
...eta1/PhishingProtectionServiceV1Beta1Settings.java 23.33% <23.33%> (ø) 2 <2> (?)
...ishingProtectionServiceV1Beta1CallableFactory.java 25% <25%> (ø) 2 <2> (?)
...1beta1/PhishingProtectionServiceV1Beta1Client.java 44.11% <44.11%> (ø) 7 <7> (?)
...ta1/stub/PhishingProtectionServiceV1Beta1Stub.java 50% <50%> (ø) 1 <1> (?)
.../PhishingProtectionServiceV1Beta1StubSettings.java 77.92% <77.92%> (ø) 10 <10> (?)
...stub/GrpcPhishingProtectionServiceV1Beta1Stub.java 78.57% <78.57%> (ø) 7 <7> (?)
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
... and 558 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0334b...fa13d37. Read the comment docs.

sduskis
sduskis previously requested changes Apr 29, 2019
View reviewed changes
kolea2
kolea2 reviewed Apr 29, 2019
View reviewed changes
@chingor13 chingor13 mentioned this pull request Apr 29, 2019
Merged
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #5026 into master will decrease coverage by <.01%.
The diff coverage is 61.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5026      +/-   ##
============================================
- Coverage     50.34%   50.33%   -0.01%     
+ Complexity    23712    23705       -7     
============================================
  Files          2244     2244              
  Lines        226295   226250      -45     
  Branches      24964    24963       -1     
============================================
- Hits         113929   113893      -36     
+ Misses       103759   103751       -8     
+ Partials       8607     8606       -1
Impacted Files Coverage Δ Complexity Δ
...eta1/PhishingProtectionServiceV1Beta1Settings.java 23.33% <23.33%> (ø) 2 <2> (?)
...ishingProtectionServiceV1Beta1CallableFactory.java 25% <25%> (ø) 2 <2> (?)
...1beta1/PhishingProtectionServiceV1Beta1Client.java 44.11% <44.11%> (ø) 7 <7> (?)
...ta1/stub/PhishingProtectionServiceV1Beta1Stub.java 50% <50%> (ø) 1 <1> (?)
.../PhishingProtectionServiceV1Beta1StubSettings.java 77.92% <77.92%> (ø) 10 <10> (?)
...stub/GrpcPhishingProtectionServiceV1Beta1Stub.java 78.57% <78.57%> (ø) 7 <7> (?)
...ta1/RecaptchaEnterpriseServiceV1Beta1Settings.java
...a1/stub/RecaptchaEnterpriseServiceV1Beta1Stub.java
...RecaptchaEnterpriseServiceV1Beta1StubSettings.java
...tub/GrpcRecaptchaEnterpriseServiceV1Beta1Stub.java
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0334b...4e1c69f. Read the comment docs.

@chingor13 chingor13 requested a review from sduskis April 30, 2019 16:23
@chingor13 chingor13 merged commit 652794a into googleapis:master May 1, 2019
@chingor13 chingor13 deleted the add-phishing branch May 1, 2019 14:36
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sduskis sduskis Awaiting requested review from sduskis

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chingor13 @codecov-io @sduskis @kolea2 @googlebot