P/S refactoring Publisher.publish #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`publish()` has a special case where the message is larger the the max byte count. That special case logic can be merged with the general scenario by using a list of `batchesToSend` rather than having a single one.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
+ Coverage 50.32% 50.32% +<.01%
+ Complexity 23680 23673 -7
============================================
Files 2238 2238
Lines 226060 226054 -6
Branches 24955 24959 +4
============================================
+ Hits 113766 113767 +1
+ Misses 103689 103683 -6
+ Partials 8605 8604 -1
Continue to review full report at Codecov.
|
kolea2
reviewed
Apr 25, 2019
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
Show resolved
Hide resolved
kolea2
approved these changes
Apr 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
+ Coverage 50.32% 50.35% +0.02%
- Complexity 23680 23706 +26
============================================
Files 2238 2238
Lines 226060 226266 +206
Branches 24955 25005 +50
============================================
+ Hits 113769 113936 +167
- Misses 103686 103725 +39
Partials 8605 8605
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish()has a special case where the message is larger the the max byte count. That special case logic can be merged with the general scenario by using a list ofbatchesToSendrather than having a single one.