Skip to content

P/S Cleaning up unused code #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
Apr 25, 2019
Merged

P/S Cleaning up unused code #5017

sduskis merged 2 commits into from
Apr 25, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 25, 2019

There are public methods in test and package private classes that were unused or had too much visibility.

@sduskis
P/S Cleaning up unused code
19eb467 
There are public methods in test and package private classes that were unused or had too much visibility.
@sduskis sduskis requested a review from a team as a code owner April 25, 2019 15:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #5017 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5017      +/-   ##
============================================
- Coverage     50.32%   49.99%   -0.34%     
+ Complexity    23680    23672       -8     
============================================
  Files          2238     2238              
  Lines        226060   226007      -53     
  Branches      24955    24191     -764     
============================================
- Hits         113766   112989     -777     
+ Misses       103689   103674      -15     
- Partials       8605     9344     +739
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 82.9% <ø> (+0.35%) 27 <0> (ø) ⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 81.06% <ø> (ø) 17 <0> (ø) ⬇️
...va/com/google/cloud/compute/v1/InstanceClient.java 48.95% <0%> (-6.46%) 139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 48.92% <0%> (-5.76%) 35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909b0e8...f4e70e9. Read the comment docs.

@sduskis sduskis merged commit 3ec7a6f into googleapis:master Apr 25, 2019
@sduskis sduskis deleted the code_cleanup branch April 25, 2019 20:47
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @kolea2 @googlebot